#171380695 user login #12

Ugizwenayo-Divine · 2020-05-27T11:23:47Z

What does this PR do?

user should be able to login

Description of Task to be completed?

Install required libraries
Create UserLogin component

How should this be manually tested?

In your terminal, run git clone https://github.com/Stackup-Rwanda/stackup2-barefoot-frontend.git to clone this repo
Run `git fetch origin ft-user-login-171380695
Run git checkout ft-user-login-171380695 to switch to the fetched branch above
Run yarn install to install all dependencies
Start the development server by running yarn dev.
The server should launch the app in your default browser at localhost:{{PORT}}
Click the login button, you will see the login form
try to login with the user in database

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#171380695

kipropbrian · 2020-06-10T14:17:28Z

src/helpers/userLogin.js

+
+const login = async (user) => {
+  let result = '';
+  const url = 'https://bft-nmd-stag.herokuapp.com/api/auth/login';


Move this URL to the .env file as it is a variable that is better handled there.

I've implemented this feedback

the22mastermind · 2020-06-10T17:00:30Z

src/actions/loginActions.js

+const loginError = (data) => ({ type: LOGIN_HANDLE, payload: data });
+
+const handleLogin = (credentials) => async (dispatch) => {
+  let output = '';


You don't need to declare this variable here. Delete this line and on line 15 do const output = token ...

the22mastermind · 2020-06-10T17:03:09Z

src/components/forms/InputField.js

+  },
+});
+
+const InputField = (props) => {


You could destructure props directly here instead of line 22.
const InputField = ({ handleLoginChange, name }) => {}

Ugizwenayo-Divine · 2020-06-11T07:17:50Z

Kudos! @Ugizwenayo-Divine
Could you take care of the following:

I followed the instructions to test this PR and when I run yarn dev I get a page with a fullscreen image, nothing else. Is this the intended scenario?

Could you make sure to remove all the commented codes?

For redux, I highly recommend you do this: Create a redux folder then inside you create a rootReducer file that will combine all the reducers

In redux folder, create a login folder and inside it put the actions, reducer and types for login.
This way it will be easier to maintain as the app scales and we have a lot of reducers and actions.

Rebase

there should be a login button to click because for me it's there

the22mastermind · 2020-06-11T07:22:54Z

Kudos! @Ugizwenayo-Divine
Could you take care of the following:

I followed the instructions to test this PR and when I run yarn dev I get a page with a fullscreen image, nothing else. Is this the intended scenario?

Could you make sure to remove all the commented codes?

For redux, I highly recommend you do this: Create a redux folder then inside you create a rootReducer file that will combine all the reducers

In redux folder, create a login folder and inside it put the actions, reducer and types for login.
This way it will be easier to maintain as the app scales and we have a lot of reducers and actions.

Rebase

there should be a login button to click because for me it's there

Could you share a screenshot? I even tried inspecting the HTML and I saw only the main div with an id of root

- user should be able to login - user should receive appropriate error message [Finishes #171380695]

Ugizwenayo-Divine added the WIP Work In Progress label May 27, 2020

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam May 27, 2020 11:24 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 7cc497a to 1246b48 Compare June 3, 2020 13:07

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 3, 2020 13:07 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 1246b48 to 283ec6a Compare June 4, 2020 14:36

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 4, 2020 14:37 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 283ec6a to 832bd81 Compare June 4, 2020 15:19

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 4, 2020 15:20 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 832bd81 to 68f9272 Compare June 4, 2020 16:46

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 4, 2020 16:47 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 68f9272 to 5db0772 Compare June 4, 2020 20:28

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 4, 2020 20:28 Inactive

Ugizwenayo-Divine added Ready for review Ready for peer review and removed WIP Work In Progress labels Jun 4, 2020

Ugizwenayo-Divine changed the title ~~(feat): userLogin~~ #171380695 user login Jun 5, 2020

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 5db0772 to 329d823 Compare June 5, 2020 12:37

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 5, 2020 12:37 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 329d823 to d28d35e Compare June 8, 2020 13:30

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 8, 2020 13:30 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from d28d35e to 0cdc6f0 Compare June 9, 2020 13:55

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 9, 2020 13:55 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 0cdc6f0 to 0375b86 Compare June 10, 2020 08:03

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 10, 2020 08:03 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 0375b86 to bfc43db Compare June 10, 2020 12:40

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 10, 2020 12:40 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from bfc43db to cf18de0 Compare June 10, 2020 12:47

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 10, 2020 12:47 Inactive

kipropbrian reviewed Jun 10, 2020

View reviewed changes

the22mastermind reviewed Jun 10, 2020

View reviewed changes

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from cf18de0 to 02dd16d Compare June 11, 2020 09:09

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 11, 2020 09:10 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 02dd16d to 7f8420a Compare June 11, 2020 10:57

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 11, 2020 10:58 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 7f8420a to 2298adb Compare June 11, 2020 11:19

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 11, 2020 11:19 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 2298adb to 0121cf8 Compare June 12, 2020 07:53

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 07:53 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 0121cf8 to 89a1c80 Compare June 12, 2020 08:00

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:01 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 89a1c80 to 5120817 Compare June 12, 2020 08:07

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:08 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 5120817 to cb7fcf4 Compare June 12, 2020 08:13

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:14 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from cb7fcf4 to 14e3e20 Compare June 12, 2020 08:30

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:31 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 14e3e20 to 5a79627 Compare June 12, 2020 08:33

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:34 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 5a79627 to ff1e1b8 Compare June 12, 2020 08:36

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:37 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch 2 times, most recently from 3852505 to 8fa2bdc Compare June 12, 2020 08:49

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:49 Inactive

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 8fa2bdc to 71a0151 Compare June 12, 2020 08:58

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 08:59 Inactive

(feat): userLogin

547377f

- user should be able to login - user should receive appropriate error message [Finishes #171380695]

Ugizwenayo-Divine force-pushed the ft-user-login-171380695 branch from 71a0151 to 547377f Compare June 12, 2020 09:06

Ugizwenayo-Divine temporarily deployed to stackup-pipe-ft-user-lo-uf8nam June 12, 2020 09:07 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

#171380695 user login #12

#171380695 user login #12

Uh oh!

Ugizwenayo-Divine commented May 27, 2020 •

edited

Loading

Uh oh!

kipropbrian Jun 10, 2020

Uh oh!

Ugizwenayo-Divine Jun 12, 2020

Uh oh!

the22mastermind Jun 10, 2020

Uh oh!

the22mastermind Jun 10, 2020

Uh oh!

Ugizwenayo-Divine commented Jun 11, 2020

Uh oh!

the22mastermind commented Jun 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

#171380695 user login #12

Are you sure you want to change the base?

#171380695 user login #12

Uh oh!

Conversation

Ugizwenayo-Divine commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Uh oh!

kipropbrian Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

Ugizwenayo-Divine Jun 12, 2020

Choose a reason for hiding this comment

Uh oh!

the22mastermind Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

the22mastermind Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

Ugizwenayo-Divine commented Jun 11, 2020

Uh oh!

the22mastermind commented Jun 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ugizwenayo-Divine commented May 27, 2020 •

edited

Loading